[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/21] qom: add object_class_get_parent
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 02/21] qom: add object_class_get_parent |
Date: |
Fri, 11 May 2012 04:25:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 02.05.2012 14:21, schrieb Andreas Färber:
> Am 02.05.2012 13:30, schrieb Paolo Bonzini:
>> This simple bit of functionality was missing and we'll need it soon,
>> so add it.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> include/qemu/object.h | 8 ++++++++
>> qom/object.c | 13 +++++++++++++
>> 2 files changed, 21 insertions(+)
>>
>> diff --git a/include/qemu/object.h b/include/qemu/object.h
>> index d315dfa..063c817 100644
>> --- a/include/qemu/object.h
>> +++ b/include/qemu/object.h
>> @@ -548,6 +548,14 @@ ObjectClass *object_class_dynamic_cast(ObjectClass
>> *klass,
>> const char *typename);
>>
>> /**
>> + * object_class_get_parent:
>> + * @klass: The class to obtain the parent for.
>> + *
>> + * Returns: The parent for @klass.
>
> Here too we should indicate that this may return NULL (rather than
> aborting). Other than that looks good.
Thanks, applied to qom-next (with extended documentation):
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next
I added Anthony's Reviewed-by from v1, since v2 only split off
documentation on my request.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches, Paolo Bonzini, 2012/05/02
- [Qemu-devel] [PATCH 01/21] qom: documentation addition, Paolo Bonzini, 2012/05/02
- [Qemu-devel] [PATCH 03/21] qom: add class_base_init, Paolo Bonzini, 2012/05/02
- [Qemu-devel] [PATCH 02/21] qom: add object_class_get_parent, Paolo Bonzini, 2012/05/02
- [Qemu-devel] [PATCH 04/21] qom: make Object a type, Paolo Bonzini, 2012/05/02
- [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field, Paolo Bonzini, 2012/05/02