qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Posting a patch?


From: Stefan Weil
Subject: Re: [Qemu-devel] Posting a patch?
Date: Mon, 14 May 2012 23:14:25 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120506 Iceowl/1.0b1 Icedove/3.0.11

Am 14.05.2012 22:53, schrieb Peter Maydell:
On 14 May 2012 21:30, Stefan Weil<address@hidden>  wrote:
if you use git for sending, you don't risk that your mailer destroys the
format of your patch.
I usually use these commands to send a single patch from the QEMU source
directory:

    # Create the patch file (name depends on the subject line of your patch).
    git format-patch HEAD^
    # Check the patch (fix any issues which were found).
    scripts/checkpatch.pl 0001-*
    # Get the maintainer who is responsible (there is not always one).
    scripts/get_maintainer.pl 0001-*
    # Send the patch.
    git send-email --to address@hidden --to "n.n<address@hidden>"
0001-*
If you do this more than once in the same git tree you'll regret it :-)
("git send-email 0001-*" will happily retransmit all the old 0001-foo
patches along with the new one...) I use git-format-patch's -o option to
put my sent patches in a separate directory so they don't clutter up the
working tree.

That's why git send-email asks before sending an email. :-)

If there are several files which match 0001-*, it will ask for
each of them.

Please read also http://wiki.qemu.org/Contribute/SubmitAPatch.
I've updated the wiki page to mention git format-patch and git send-email.
Does anybody have a link to a decent short tutorial on how to use them?
If so, I think it would probably be helpful for us to put a link on the
SubmitAPatch page.

-- PMM

I just added links to the man pages.
Of course a tutorial would be even better.

Regards,
Stefan W.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]