[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdu
From: |
jim |
Subject: |
[Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdup |
Date: |
Tue, 15 May 2012 15:04:38 +0200 |
From: Jim Meyering <address@hidden>
This avoids a NULL-deref upon strdup failure.
Also update matching free to g_free.
Signed-off-by: Jim Meyering <address@hidden>
---
target-sparc/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index 7ac6bdb..1e31318 100644
--- a/target-sparc/cpu.c
+++ b/target-sparc/cpu.c
@@ -648,7 +648,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def,
const char *cpu_model)
{
unsigned int i;
const sparc_def_t *def = NULL;
- char *s = strdup(cpu_model);
+ char *s = g_strdup(cpu_model);
char *featurestr, *name = strtok(s, ",");
uint32_t plus_features = 0;
uint32_t minus_features = 0;
@@ -740,7 +740,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def,
const char *cpu_model)
#ifdef DEBUG_FEATURES
print_features(stderr, fprintf, cpu_def->features, NULL);
#endif
- free(s);
+ g_free(s);
return 0;
error:
--
1.7.10.2.484.gcd07cc5
- [Qemu-devel] [PATCH 0/3] unchecked uses of strdup, jim, 2012/05/15
- [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, jim, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Blue Swirl, 2012/05/19
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Jim Meyering, 2012/05/21
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Blue Swirl, 2012/05/21
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Kevin Wolf, 2012/05/22
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Jim Meyering, 2012/05/22
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Kevin Wolf, 2012/05/22
- Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure, Jim Meyering, 2012/05/22
[Qemu-devel] [PATCH 3/3] sparc: use g_strdup in place of unchecked strdup,
jim <=
[Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL, jim, 2012/05/15
- Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL, Paolo Bonzini, 2012/05/15
- Re: [Qemu-devel] [PATCH 2/3] scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL, Kevin Wolf, 2012/05/15