Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

[Paolo Bonzini]

----- Messaggio originale -----
> Da: "Paolo Bonzini" <address@hidden>
> A: "Andreas Färber" <address@hidden>
> Cc: "Jan Kiszka" <address@hidden>, address@hidden, address@hidden
> Inviato: Mercoledì, 16 maggio 2012 9:40:12
> Oggetto: Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in 
> info qtree
>
> > Am 03.04.2012 15:05, schrieb Paolo Bonzini:
> > > Il 03/04/2012 14:28, Jan Kiszka ha scritto:
> > >>>>          if (object_property_get_type(OBJECT(dev),
> > >>>>          legacy_name,
> > >>>>          NULL)) {
> > >>>>              value = object_property_get_str(OBJECT(dev),
> > >>>>              legacy_name, &err);
> > >> [...] We should either
> > >> assert(print && parse) or handle their non-existence properly.
> > >
> > > Yes, asserting that print/parse are always present in pairs (if
> > > at
> > > all) would be good.
> >
> > Paolo, has this issue been addressed somewhere?
>
> No, but it's a simple assertion.  It doesn't look like 1.1 material.
> I should send and rebase the bus series today, I'll include it.

Doh, it was handled by

commit 68ee356941801d0a17fdc43b11ac3e6b72fcd597
Author: Paolo Bonzini <address@hidden>
Date:   Thu Feb 2 10:17:19 2012 +0100

    qdev: allow reusing get/set for legacy property

print/parse do not have to be present in pairs anymore.

Paolo