[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upo
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upon failed lockf |
Date: |
Wed, 16 May 2012 15:58:42 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 16, 2012 at 10:19:55PM +0200, Jim Meyering wrote:
>
> Signed-off-by: Jim Meyering <address@hidden>
Acked-by: Michael Roth <address@hidden>
> ---
>
> qemu-ga.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index 680997e..24b236a 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -246,6 +246,9 @@ static bool ga_open_pidfile(const char *pidfile)
> pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
> if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
> g_critical("Cannot lock pid file, %s", strerror(errno));
> + if (pidfd != -1) {
> + close(pidfd);
> + }
> return false;
> }
>
> --
> 1.7.10.2.520.g6a4a482
>
- Re: [Qemu-devel] [PATCH 5/6] arm-semi: don't leak 1kb user string lock buffer upon TARGET_SYS_OPEN, (continued)