Re: [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global.

[Andreas Färber]

Am 23.05.2012 14:44, schrieb Peter Maydell:
> On 20 May 2012 10:02, Gleb Natapov <address@hidden> wrote:
>> There can be only one fw_cfg device, so saving global reference to it
>> removes the need to pass its pointer around.
> 
> This seems like a backwards step to me: one of the things that prevents
> us supporting "two separate machines in one emulation" is that we have
> various things that assume there's only one instance of themselves and
> use globals. I don't think we should be adding any more...

While I concur with the design sentiment of avoiding globals where
possible, I can understand having multiple CPU types in one machine, but
multiple machines in one emulation? Do you have a specific example that
cannot easily be modeled as multiple socket-connected executables?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg