[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without eff
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host |
Date: |
Mon, 28 May 2012 13:47:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-05-28 00:10, Peter Maydell wrote:
> On 27 May 2012 17:42, Andreas Färber <address@hidden> wrote:
>> +# if defined(__APPLE__)
>> +# undef NTOHL
>> +# undef NTOHS
>> +# undef HTONL
>> +# undef HTONS
>> +# define NTOHL(d) do { } while (0)
>> +# define NTOHS(d) do { } while (0)
>> +# define HTONL(d) do { } while (0)
>> +# define HTONS(d) do { } while (0)
>> +# else
>
> We could just use this for everything, not just if __APPLE__,
> right? For big-endian the semantics we want are always "do
> nothing" so it's always OK to undef and redefine...
> That would save having a special case.
Yes, please.
Jan
signature.asc
Description: OpenPGP digital signature