qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 1.1] virtio: Fix compiler warning for non Linux hosts
Date: Wed, 30 May 2012 08:33:03 +0100

On Wed, May 30, 2012 at 3:26 AM, Anthony Liguori <address@hidden> wrote:
> 3) It's not how the rest of QEMU is written.  Consistency is the most
> important purpose of Coding Style.
>
> (3) is the most important consideration of all.

Fair enough if its a style choice and you want QEMU to be consistent.
I'd love to use them because they keep variables and the code that
uses them together - great for checking that correct types are being
used during code review and also less noise in the patch.

So if you ever change your mind about this, let me know and I'll never
declare a variable at the start of a function again :D.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]