Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

[Pavel Hrdina]

On 05/30/2012 04:19 PM, Kevin Wolf wrote:
> Am 30.05.2012 12:01, schrieb Pavel Hrdina:
> > For debug it would be nice to have a same functionality for the qmp monitor
> > on stdio as the hmp monitor on stdio has. For this purpose we also use
> > readline mode for qmp monitor on stdio.
> >
> > Because we don't need anymore an echo function for stdio, there is also revert 
> > of
> > a commit, which added this functionality.
> Thanks, this will be really helpful when using QMP manually!
>
> You'll probably want to disable the tab completion though, it assumes
> HMP commands (unless you want to make a working QMP completion, which
> would be very cool, but probably isn't worth the effort).

Thanks for the tab completion reminder. I forget to handle it
> Another thing I thought of is that we could already add one entry to the
> readline history on qemu start: {"execute":"qmp_capabilities"} You're
> very likely to use this command as the first thing in your QMP session.
>
> Kevin

I think the entry in the readline history after start would be a hack. I 
would have to make the readline_hist_add function not static and create 
definition in a header file. Than I'll have to call it as 
readline_hist_add(mon->rs, "{\"execute\":\"qmp_capabilites\"}") after 
readline initialization.

Pavel