|
From: | Pavel Hrdina |
Subject: | Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio |
Date: | Wed, 30 May 2012 18:00:41 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 05/30/2012 04:19 PM, Kevin Wolf wrote:
Am 30.05.2012 12:01, schrieb Pavel Hrdina:For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need anymore an echo function for stdio, there is also revert of a commit, which added this functionality.Thanks, this will be really helpful when using QMP manually! You'll probably want to disable the tab completion though, it assumes HMP commands (unless you want to make a working QMP completion, which would be very cool, but probably isn't worth the effort).
Thanks for the tab completion reminder. I forget to handle it
Another thing I thought of is that we could already add one entry to the readline history on qemu start: {"execute":"qmp_capabilities"} You're very likely to use this command as the first thing in your QMP session. Kevin
I think the entry in the readline history after start would be a hack. I would have to make the readline_hist_add function not static and create definition in a header file. Than I'll have to call it as readline_hist_add(mon->rs, "{\"execute\":\"qmp_capabilites\"}") after readline initialization.
Pavel
[Prev in Thread] | Current Thread | [Next in Thread] |