Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

[Kevin Wolf]

Am 31.05.2012 15:06, schrieb Paolo Bonzini:
> Il 31/05/2012 14:33, Paolo Bonzini ha scritto:
>>>>>>>>          case 0x02: /* write cache enable */
>>>>>>>> +            bdrv_set_enable_write_cache(s->bs, true);
>>>>>>>> +            identify_data = (uint16_t *)s->identify_data;
>>>>>>>> +            put_le16(identify_data + 85, (1 << 14) | (1 << 5) | 1);
>>>> How about just s->identify_set = 0; instead, so that all IDENTIFY logic
>>>> stays together in one place?
>>>>
>> Good idea.
> 
> Hmm, this is a rat's nest because of the other patching we do for "set
> transfer mode".  I'd prefer to refactor it later.

I wasn't aware of that... Okay, then whatever you like better, either
add another refactoring patch before this one for v2, or just keep it as
it is and we'll get to it later.

Kevin