Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

[Jan Kiszka]

On 2012-05-31 15:49, Luigi Rizzo wrote:
> On Thu, May 31, 2012 at 03:23:12PM +0200, Jan Kiszka wrote:
>> On 2012-05-31 15:19, Paolo Bonzini wrote:
>>> Il 31/05/2012 15:07, Zhi Yong Wu ha scritto:
>>>> Yeah, this case actually exists, but tcp/ip protocol stack in guest
>>>> will make sure this ordering will finally be correct.
>>>
>>> Nevertheless it's not good, and the latest Windows Logo tests will fail
>>> if you reorder frames.
>>
>> Can we really enter qemu_net_queue_send with delivering == 0 and a
>> non-empty queue?
> 
> i have no idea.
> 
> it doesn't help that comments are using very very
> sparingly throughout the code...

You may find more hints in the commit logs.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux