Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

[Luiz Capitulino]

On Thu, 31 May 2012 17:18:18 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 31/05/2012 15:49, Luiz Capitulino ha scritto:
> >> Seriously? The natural thing to do is -qmp stdio, and I don't read any
> >> wikis for that.
> >>
> >> It's nice that you can get some kind of usability by typing in long
> >> network addresses or path names and hacking a rlwrap around it (didn't
> >> know this one yet), but it's not stuff I want to deal with. It should
> >> just work.
> > 
> > I'm not opposed to having this somewhere else, but adding a crude hack down
> > QMP low-levels just to have readline support while the same functionality
> > can be achieved by using a simple tool doesn't make much sense to me.
> 
> We can at least clean up the code so that it doesn't look like a hack,
> and so that there is limited or no duplication between HMP and QMP code.

I think the best (and maybe the only acceptable) way of having this in qemu
is to not implement it in QMP, but in higher layers. The chardev layer comes
to my mind.