|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time |
Date: | Thu, 07 Jun 2012 11:16:13 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 06/06/2012 07:54 PM, Paolo Bonzini wrote:
From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 From: Anthony Liguori<address@hidden> Date: Wed, 6 Jun 2012 16:57:00 +0800 Subject: [PATCH] configure: ensure directory exists when creating symlink Signed-off-by: Anthony Liguori<address@hidden> --- configure | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 07e3ff1..4a7f027 100755 --- a/configure +++ b/configure @@ -42,6 +42,7 @@ compile_prog() { # symbolically link $1 to $2. Portable version of "ln -sf". symlink() { rm -rf "$2" + mkdir -p `dirname $2`Please leave the argument quoted, like dir=`dirname "$2` mkdir -p "$dir" Otherwise looks good. Do we need a v3? This can just be committed before 25/25 or even before all my patches, and that would be just what I send.
Unfortunately, this conflicts pretty badly with Andreas' QOM CPU series. Could you rebase and send out a v3?
Regards, Anthony Liguori
Paololn -s "$1" "$2" } @@ -3454,14 +3455,12 @@ if test -f ${config_host_ld}~ ; then fi for d in libdis libdis-user; do - mkdir -p $d symlink "$source_path/Makefile.dis" "$d/Makefile" echo> $d/config.mak done # use included Linux headers if test "$linux" = "yes" ; then - mkdir -p linux-headers case "$cpu" in i386|x86_64) symlink "$source_path/linux-headers/asm-x86" linux-headers/asm -- 1.7.5.4
[Prev in Thread] | Current Thread | [Next in Thread] |