[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/9] alpha-linux-user: Fix a3 error return with v0 e
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 7/9] alpha-linux-user: Fix a3 error return with v0 error bypass. |
Date: |
Thu, 7 Jun 2012 15:24:29 -0700 |
We were failing to initialize a3 for syscalls that bypass the
negative return value error check.
Signed-off-by: Richard Henderson <address@hidden>
---
linux-user/main.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index e81abb2..605018a 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2758,13 +2758,11 @@ void cpu_loop(CPUAlphaState *env)
break;
}
/* Syscall writes 0 to V0 to bypass error check, similar
- to how this is handled internal to Linux kernel. */
- if (env->ir[IR_V0] == 0) {
- env->ir[IR_V0] = sysret;
- } else {
- env->ir[IR_V0] = (sysret < 0 ? -sysret : sysret);
- env->ir[IR_A3] = (sysret < 0);
- }
+ to how this is handled internal to Linux kernel.
+ (Ab)use trapnr temporarily as boolean indicating error. */
+ trapnr = (env->ir[IR_V0] != 0 && sysret < 0);
+ env->ir[IR_V0] = (trapnr ? -sysret : sysret);
+ env->ir[IR_A3] = trapnr;
break;
case 0x86:
/* IMB */
--
1.7.7.6
- Re: [Qemu-devel] [PATCH 2/9] alpha-linux-user: Work around hosted mmap allocation problems, (continued)
[Qemu-devel] [PATCH 3/9] alpha-linux-user: Handle TARGET_SSI_IEEE_RAISE_EXCEPTION properly, Richard Henderson, 2012/06/07
[Qemu-devel] [PATCH 6/9] linux-user: Translate pipe2 flags; add to strace, Richard Henderson, 2012/06/07
[Qemu-devel] [PATCH 5/9] linux-user: Allocate the right amount of space for non-fixed file maps, Richard Henderson, 2012/06/07
[Qemu-devel] [PATCH 4/9] linux-user: Handle O_SYNC, O_NOATIME, O_CLOEXEC, O_PATH, Richard Henderson, 2012/06/07
[Qemu-devel] [PATCH 7/9] alpha-linux-user: Fix a3 error return with v0 error bypass.,
Richard Henderson <=
[Qemu-devel] [PATCH 9/9] alpha-linux-user: Fix the getpriority syscall, Richard Henderson, 2012/06/07
[Qemu-devel] [PATCH 8/9] alpha-linux-user: Properly handle the non-rt sigprocmask syscall., Richard Henderson, 2012/06/07
Re: [Qemu-devel] [PATCH v3 0/9] {alpha-}linux user improvements, Richard Henderson, 2012/06/12