[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] target-i386: Use uint32 visitor for [x]level pr
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH 8/8] target-i386: Use uint32 visitor for [x]level properties |
Date: |
Fri, 8 Jun 2012 17:35:13 +0200 |
This simplifies the code and resolves TODOs.
Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
---
target-i386/cpu.c | 42 ++++--------------------------------------
1 files changed, 4 insertions(+), 38 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 388bc5c..0b61162 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -723,66 +723,32 @@ static void x86_cpuid_get_level(Object *obj, Visitor *v,
void *opaque,
const char *name, Error **errp)
{
X86CPU *cpu = X86_CPU(obj);
- int64_t value;
- value = cpu->env.cpuid_level;
- /* TODO Use visit_type_uint32() once available */
- visit_type_int(v, &value, name, errp);
+ visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
}
static void x86_cpuid_set_level(Object *obj, Visitor *v, void *opaque,
const char *name, Error **errp)
{
X86CPU *cpu = X86_CPU(obj);
- const int64_t min = 0;
- const int64_t max = UINT32_MAX;
- int64_t value;
-
- /* TODO Use visit_type_uint32() once available */
- visit_type_int(v, &value, name, errp);
- if (error_is_set(errp)) {
- return;
- }
- if (value < min || value > max) {
- error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, "",
- name ? name : "null", value, min, max);
- return;
- }
- cpu->env.cpuid_level = value;
+ visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
}
static void x86_cpuid_get_xlevel(Object *obj, Visitor *v, void *opaque,
const char *name, Error **errp)
{
X86CPU *cpu = X86_CPU(obj);
- int64_t value;
- value = cpu->env.cpuid_xlevel;
- /* TODO Use visit_type_uint32() once available */
- visit_type_int(v, &value, name, errp);
+ visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
}
static void x86_cpuid_set_xlevel(Object *obj, Visitor *v, void *opaque,
const char *name, Error **errp)
{
X86CPU *cpu = X86_CPU(obj);
- const int64_t min = 0;
- const int64_t max = UINT32_MAX;
- int64_t value;
-
- /* TODO Use visit_type_uint32() once available */
- visit_type_int(v, &value, name, errp);
- if (error_is_set(errp)) {
- return;
- }
- if (value < min || value > max) {
- error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, "",
- name ? name : "null", value, min, max);
- return;
- }
- cpu->env.cpuid_xlevel = value;
+ visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
}
static char *x86_cpuid_get_vendor(Object *obj, Error **errp)
--
1.7.7
- [Qemu-devel] [PULL] qom-next queue, first batch: fixed-width visitors, Andreas Färber, 2012/06/08
- [Qemu-devel] [PATCH 5/8] qdev: Use int32_t container for devfn property, Andreas Färber, 2012/06/08
- [Qemu-devel] [PATCH 3/8] qapi: String visitor, use %f representation for floats, Andreas Färber, 2012/06/08
- [Qemu-devel] [PATCH 4/8] qapi: Add String visitor coverage to serialization unit tests, Andreas Färber, 2012/06/08
- [Qemu-devel] [PATCH 8/8] target-i386: Use uint32 visitor for [x]level properties,
Andreas Färber <=
- [Qemu-devel] [PATCH 6/8] qdev: Switch property accessors to fixed-width visitor interfaces, Andreas Färber, 2012/06/08
- [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t, Andreas Färber, 2012/06/08
[Qemu-devel] [PATCH 2/8] qapi: Unit tests for visitor-based serialization, Andreas Färber, 2012/06/08
[Qemu-devel] [PATCH 7/8] qdev: Remove PropertyInfo range checking, Andreas Färber, 2012/06/08
Re: [Qemu-devel] [PULL] qom-next queue, first batch: fixed-width visitors, Andreas Färber, 2012/06/08
Re: [Qemu-devel] [PULL] qom-next queue, first batch: fixed-width visitors, Luiz Capitulino, 2012/06/11