qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/4] hw: introduce standard SD host controlle


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v3 1/4] hw: introduce standard SD host controller
Date: Sat, 09 Jun 2012 17:23:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite:
> From: Igor Mitsyanko <address@hidden>
> 
> Device model for standard SD Host Controller Interface (SDHCI) compliant with
> version 2.00 of SD association specification.
> 
> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> Signed-off-by: Igor Mitsyanko <address@hidden>
[...]
> diff --git a/hw/sdhci.h b/hw/sdhci.h
> new file mode 100644
> index 0000000..afd0772
> --- /dev/null
> +++ b/hw/sdhci.h
> @@ -0,0 +1,310 @@
[...]
> +#ifndef _SDHC_H_
> +#define _SDHC_H_
[...]
> +#endif /* _SDHC_H_ */

Minor nit: Our malc insists on not using reserved identifiers starting
with underscore. s/_SDHC_H_/SDHCI_H/g ?

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]