Re: [Qemu-devel] [patch V9 0/5] i.MX31: Add initial support

[Andreas Färber]

Am 07.06.2012 05:31, schrieb address@hidden:
> Changes since V8: Recovered my stuff-up from backup --- changes that
>       were in V7 are back in!
>       Andreas's comments addressed

> (except adding MAINTAINER field)

Why? Are you unwilling to maintain the code you contribute, or do you
have questions on placement, format or something we can help resolve?

The Makefile system has changed by now. The way you're adding the files
you could move them to hw/arm/Makefile.objs. I'd suggest to add a
CONFIG_IMX=y in default-configs/arm-softmmu.mak and to add the
CPU-independent files (serial, ccm, timer, even avic apparently) to
hw/Makefile.objs instead using hw-obj-$(CONFIG_IMX).
For an example see my Tegra2 branch:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/tegra

Andreas

>       Peter Maydell's comments against V6/7 are addressed.
> 
> Peter C

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg