[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 |
Date: |
Thu, 14 Jun 2012 18:20:54 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 12/06/12 01:25, Luiz Capitulino wrote:
Hi Luiz, Anthony
BTW, why is there a 16 keycode limit?
'Sendkey' command was added by this commit
a3a91a355bc6107b7d06d722fb97d2b80065ee0b
Limitation of keycodes number (16) was also introduced here,
and I didn't find the root reason.
That's a good point. This comes form the array used by the original
implementation to store the keycodes.
Amos, is it still needed now that we're using qapi lists?
I try to drop this limitation from monitor.c [1], then execute
(qemu) sendkey 1-2-3-4-5-6-7-8-9-0-1-2-3-4-5-6-7-8-9-0
kbd_put_keycode() are called for all (20) keycodes,
but only '123456789012345' can be sent to guest.
It seems we need to notice user when inputted keys are more than 16.
[1]
https://github.com/kongove/QEMU/commit/a198cdcce3ce4c1632221ac7f1e7c4e8efcd9c82
--
Amos.
- [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi, Amos Kong, 2012/06/01
- [Qemu-devel] [PATCH v2 1/6] qerror: add QERR_OVERFLOW, Amos Kong, 2012/06/01
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add QERR_OVERFLOW, Anthony Liguori, 2012/06/04
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Amos Kong, 2012/06/05
- Message not available
- Message not available
- Message not available
- Message not available
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16,
Amos Kong <=
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Amos Kong, 2012/06/15
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Gerd Hoffmann, 2012/06/15
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Luiz Capitulino, 2012/06/15
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Amos Kong, 2012/06/18
- Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16, Amos Kong, 2012/06/19
[Qemu-devel] [PATCH v2 2/6] fix doc of using raw values with sendkey, Amos Kong, 2012/06/01
[Qemu-devel] [PATCH v2 4/6] hmp: rename arguments, Amos Kong, 2012/06/01
[Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less', Amos Kong, 2012/06/01