qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item


From: Alex Williamson
Subject: [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item
Date: Thu, 14 Jun 2012 12:16:28 -0600
User-agent: StGIT/0.14.3

MSIX, like PCI, is little endian.  Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.

Signed-off-by: Alex Williamson <address@hidden>
---

 hw/msix.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/msix.c b/hw/msix.c
index 50885ac..87d316a 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, 
target_phys_addr_t addr,
 static const MemoryRegionOps msix_mmio_ops = {
     .read = msix_mmio_read,
     .write = msix_mmio_write,
+    /* TODO: MSIX should be LITTLE_ENDIAN. */
     .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,




reply via email to

[Prev in Thread] Current Thread [Next in Thread]