[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JO
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE |
Date: |
Fri, 15 Jun 2012 10:51:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
> The DeviceNotActive error is not a particularly good match, add
> a separate one.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockdev.c | 4 ++--
> qapi-schema.json | 5 ++---
> qerror.c | 4 ++++
> qerror.h | 3 +++
> 4 files changed, 11 insertions(+), 5 deletions(-)
Looks reasonable, but it will affect libvirt: Right now, libvirt parses
the particular return code (qemu_monitor.c:qemuMonitorJSONBlockJob), and
translates
DeviceNotActive => "No active operation on device"
...
all others => "Unexpected error"
so if this patch goes in but libvirt doesn't match, then libvirt will
have a regression in error message quality. Not the end of the world,
though, so don't hold back just because of libvirt.
Reviewed-by: Eric Blake <address@hidden>
> @@ -1679,8 +1679,7 @@
> # @device: the device name
> #
> # Returns: Nothing on success
> -# If no background operation is active on this device,
> DeviceNotActive
> -# If cancellation already in progress, DeviceInUse
> +# If no background operation is active on this device,
> BlockJobNotActive
What happened to DeviceInUse?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 00/36] A peek at the current block job patches, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 01/36] qapi: generalize documentation of streaming commands, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE, Paolo Bonzini, 2012/06/15
- Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 04/36] block: add block_job_query, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 03/36] block: move job APIs to separate files, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 06/36] qmp: add block-job-pause and block-job-resume, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 05/36] block: add support for job pause/resume, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 08/36] block: rename block_job_complete to block_job_completed, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 07/36] qemu-iotests: add test for pausing a streaming operation, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 10/36] block: move BlockdevOnError declaration to QAPI, Paolo Bonzini, 2012/06/15