[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary |
Date: |
Sun, 17 Jun 2012 14:30:21 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
On 06/17/2012 02:03 PM, Jan Kiszka wrote:
> On 2012-06-17 10:47, Avi Kivity wrote:
>> kvm is not able to execute out of partial pages; align the RAM size
>> so partial pages aren't present.
>>
>> Reported-by: Michael Tokarev <address@hidden>
>> Signed-off-by: Avi Kivity <address@hidden>
>> ---
>> kvm-all.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 4ea7d85..482768f 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -1311,6 +1311,8 @@ int kvm_init(void)
>>
>> cpu_interrupt_handler = kvm_handle_interrupt;
>>
>> + ram_size = TARGET_PAGE_ALIGN(ram_size);
>> +
>> return 0;
>>
>> err:
>
> I think this should rather go into generic code.
To be honest, I put this in kvm-specific code because vl.c doesn't have
TARGET_PAGE_ALIGN. Maybe we should have machine->page_size or
machine->ram_alignment.
> What sense does it make
> to have partial pages with TCG?
Why impose an artificial restriction?
(answer: to reduce differences among various accelerators)
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Avi Kivity, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Jan Kiszka, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Jan Kiszka, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Avi Kivity, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Blue Swirl, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Peter Maydell, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Avi Kivity, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Blue Swirl, 2012/06/17
- Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary, Avi Kivity, 2012/06/17