[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions |
Date: |
Fri, 22 Jun 2012 12:02:59 +1000 |
On Wed, 2012-06-20 at 16:16 -0500, Anthony Liguori wrote:
> > diff --git a/qemu-common.h b/qemu-common.h
> > index 8f87e41..80026af 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> > typedef struct VirtIODevice VirtIODevice;
> > typedef struct QEMUSGList QEMUSGList;
> > typedef struct SHPCDevice SHPCDevice;
> > +typedef struct DMAContext DMAContext;
>
> Please don't put this in qemu-common.h. Stick it in a dma-specific
> header.
Ok so I just removed it from qemu-common.h (it's already in dma.h). It
causes a minor breakage in spapr which is easily fixed by adding the
right include.
I'm building all the targets now and .... it seems to pass.
So it's gone. That does mean that Jason will probably have to change
something to his patches though.
Cheers,
Ben.
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, (continued)
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, David Gibson, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions,
Benjamin Herrenschmidt <=
[Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Gerd Hoffmann, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, David Gibson, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, David Gibson, 2012/06/20
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Gerd Hoffmann, 2012/06/20
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Gerd Hoffmann, 2012/06/20
[Qemu-devel] [PATCH 11/13] iommu: Allow PCI to use IOMMU infrastructure, Benjamin Herrenschmidt, 2012/06/19