[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opene
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd |
Date: |
Mon, 25 Jun 2012 17:26:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 25.06.2012 16:34, schrieb Eric Blake:
>> Also, I noticed in the fnctl man page that F_SETFL: "On Linux this
>> command can change only the O_APPEND, O_ASYNC, O_DIRECT, O_NOATIME, and
>> O_NONBLOCK flags." So I'll only set/unset these flags.
>
> O_NDELAY is the obsolete spelling of O_NONBLOCK; which means the only
> other flags in your list not supported by Linux are O_LARGEFILE (which I
> said was pointless), O_NOCTTY (which only has an impact at open() and
> not later on, so it is not worth worrying about), and O_SYNC (so for
> that one, you should error out if not set correctly, as the difference
> between O_SYNC on vs. off is significant).
As far as I know, newer kernels can change O_SYNC with fcntl, so it's
probably worth trying, but you'd have to check if it has really been set.
Kevin
- Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd, (continued)
[Qemu-devel] [PATCH v4 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg, Corey Bryant, 2012/06/22
[Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd, Corey Bryant, 2012/06/22
[Qemu-devel] [PATCH v4 5/7] block: Prevent /dev/fd/X filename from being detected as floppy, Corey Bryant, 2012/06/22
[Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions, Corey Bryant, 2012/06/22
[Qemu-devel] [PATCH v4 6/7] block: Convert open calls to qemu_open, Corey Bryant, 2012/06/22