Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> On 06/25/2012 03:47 PM, Andreas Färber wrote:
[...]
>> As for convenience, personally I find all these property API signatures
>> inconvenient enough that I copy&paste when I add a new one or need to
>> look up object.h. The inconsistent or at least unintuitive order of
>> value and name is also quite confusing for me. When I want to add a
>> child<>  property I think, to object obj (that's always first for
>> object_* functions) add a property "foo" with value "bar", but as it is
>> the value goes before the name. Maybe a matter of taste.
>
> The various object_property_set_* functions are inconsistent because I
> didn't write them.  I'm not sure why they take value/name.  They
> should take name/value IMHO.

Fix them all?

[...]