[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: do not blindly memset all
From: |
MORITA Kazutaka |
Subject: |
Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: do not blindly memset all read buffers |
Date: |
Mon, 02 Jul 2012 18:33:50 +0900 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/22.2 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Fri, 29 Jun 2012 17:38:24 +0200,
Christoph Hellwig wrote:
> >
> > > goto done;
> > > }
> > > -
> > > - create = 1;
> > > - } else if (acb->aiocb_type == AIOCB_WRITE_UDATA
> > > - && !is_data_obj_writable(inode, idx)) {
> > > - /* Copy-On-Write */
> > > - create = 1;
> > > - old_oid = oid;
> > > - flags = SD_FLAG_CMD_COW;
> > > + break;
> > > + case AIOCB_WRITE_UDATA:
> >
> > Wrong indentation.
>
> Where? At least I can't find anything obvious and checkpath.pl is fine
> with the patch, too.
It seems that there is a redundant space before "case AIOCB_WRITE_UDATA:".
==
$ ./scripts/checkpatch.pl your.patch
ERROR: switch and case should be at the same indent
#92: FILE: block/sheepdog.c:1560:
+ switch (acb->aiocb_type) {
[...]
+ case AIOCB_WRITE_UDATA:
total: 1 errors, 0 warnings, 55 lines checked
c.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: do not blindly memset all read buffers,
MORITA Kazutaka <=