[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessi
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c |
Date: |
Wed, 11 Jul 2012 16:35:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 10.07.2012 11:12, schrieb Markus Armbruster:
>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
>> except it was put into block.c. Device-specific functionality should
>> be kept in device code, not the block layer. Move it to
>> hw/hd-geometry.c, and make stylistic changes required to keep
>> checkpatch.pl happy.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> block.c | 121 ---------------------------------------
>> block.h | 1 -
>> blockdev.h | 1 +
>> hw/Makefile.objs | 2 +-
>> hw/block-common.h | 21 +++++++
>> hw/hd-geometry.c | 162
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> hw/ide/core.c | 3 +-
>> hw/scsi-disk.c | 5 +-
>> hw/virtio-blk.c | 3 +-
>> 9 files changed, 192 insertions(+), 127 deletions(-)
>> create mode 100644 hw/block-common.h
>> create mode 100644 hw/hd-geometry.c
>
>> diff --git a/blockdev.h b/blockdev.h
>> index 260e16b..26454c9 100644
>> --- a/blockdev.h
>> +++ b/blockdev.h
>> @@ -62,4 +62,5 @@ void qmp_change_blockdev(const char *device, const char
>> *filename,
>> bool has_format, const char *format, Error **errp);
>> void do_commit(Monitor *mon, const QDict *qdict);
>> int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data);
>> +
>> #endif
>
> Any objections against dropping this hunk before applying?
>
> Kevin
Nope.
- [Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation, (continued)
- [Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 13/29] blockdev: Save geometry in DriveInfo, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 18/29] ide: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 16/29] scsi-hd: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 17/29] virtio-blk: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 19/29] qtest: Cover qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 27/29] hd-geometry: Compute BIOS CHS translation in one place, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 23/29] qtest: Cover qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 24/29] block: Geometry and translation hints are now useless, purge them, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 22/29] ide: qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 28/29] blockdev: Drop redundant CHS validation for if=ide, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 26/29] qtest: Test we don't put hard disk info into CMOS for a CD-ROM, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 25/29] ide pc: Put hard disk info into CMOS only for hard disks, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 20/29] qdev: Collect private helpers in one place, Markus Armbruster, 2012/07/10
- Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup, Kevin Wolf, 2012/07/11