Re: [Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument

[Paolo Bonzini]

Il 15/06/2012 19:58, Eric Blake ha scritto:
> On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
>> This patch adds support for error management to streaming.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  block/stream.c   |   28 +++++++++++++++++++++++++++-
>>  block_int.h      |    3 ++-
>>  blockdev.c       |   11 ++++++++---
>>  hmp.c            |    3 ++-
>>  qapi-schema.json |    9 ++++++---
>>  qmp-commands.hx  |    2 +-
>>  6 files changed, 46 insertions(+), 10 deletions(-)
>>
> 
>> +++ b/qapi-schema.json
>> @@ -1650,6 +1650,8 @@
>>  #
>>  # @speed:  #optional the maximum speed, in bytes per second
>>  #
>> +# @on_error: #optional the action to take on an error (default report)
>> +#
>>  # Returns: Nothing on success
>>  #          If streaming is already active on this device, DeviceInUse
>>  #          If @device does not exist, DeviceNotFound
>> @@ -1657,10 +1659,11 @@
>>  #          If @base does not exist, BaseNotFound
>>  #          If @speed is invalid, InvalidParameter
> 
> Should you mention the possibility of the new
> QERR_INVALID_PARAMETER_COMBINATION error when on_error requests an
> action that the device doesn't support?

Yes, but I'll just change it to InvalidParameter.

>>  #
>> -# Since: 1.1
>> +# Since: 1.1, on_error since 1.2
> 
> First instance of a double since.  I like the idea; should we be using
> it in more places?

Yes, but I'll move the "since" to the description of on_error.