qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] improve scripts/make-release


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] improve scripts/make-release
Date: Wed, 18 Jul 2012 08:41:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/18/2012 08:31 AM, Gerd Hoffmann wrote:
> 'make dist' creates a tarball for the current checkout.
> 'make qemu-${version}.tar.bz2' creates a tarball for git tag v${version}.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  Makefile             |    5 ++---
>  scripts/make-release |    8 +++++++-
>  2 files changed, 9 insertions(+), 4 deletions(-)

> +++ b/scripts/make-release
> @@ -12,11 +12,17 @@
>  
>  src="$1"
>  version="$2"
> +if test "$version" = ""; then

test ! "$version"

is less typing, and still POSIX compliant.

> +     commit=$(git describe --long)
> +     version="${commit#v}"

Sticking with my earlier theme started against Anthony's original
implementation of this script, in complaining about inconsistent shell
quoting styles, it might look nicer to favor minimal quoting:

commit=$(git describe --long)
version=${commit#v}

or maximal quoting:

commit="$(git describe --long)"
version="${commit#v}"

rather than an ad hoc mix.  But as that is cosmetic, and does not impact
functionality, you have my:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]