[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, s
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, strings. |
|
Date: |
Thu, 19 Jul 2012 12:52:29 +0100 |
On Thu, Jul 19, 2012 at 12:07 PM, Harsh Prateek Bora
<address@hidden> wrote:
> Existing simpletrace backend allows to trace at max 6 args and does not
> support strings. This newer tracelog format gets rid of fixed size records
> and therefore allows to trace variable number of args including strings.
>
> Sample trace:
> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff
> uname=nobody aname=
> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80
> version=0x4f2a4dd0 path=0x220ea6
>
> v9:
> - Renamed TraceRecordHeader to TraceLogHeader as appropriate
> - Some more code cleanups
We discussed this on IRC. v8 is already in my tracing tree and I have
sent a pull request.
These code cleanups are nice but can be taken in a follow-up patch.
Stefan