[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring
From: |
Harsh Prateek Bora |
Subject: |
[Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring |
Date: |
Fri, 20 Jul 2012 18:52:15 +0530 |
Signed-off-by: Harsh Prateek Bora <address@hidden>
---
trace/simple.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 4fed07f..8e175ec 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -269,12 +269,11 @@ static unsigned int write_to_buffer(unsigned int idx,
void *dataptr, size_t size
void trace_record_finish(TraceBufferRecord *rec)
{
- uint8_t temp_rec[sizeof(TraceRecord)];
- TraceRecord *record = (TraceRecord *) temp_rec;
- read_from_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ TraceRecord record;
+ read_from_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
smp_wmb(); /* write barrier before marking as valid */
- record->event |= TRACE_RECORD_VALID;
- write_to_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ record.event |= TRACE_RECORD_VALID;
+ write_to_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
if ((trace_idx - writeout_idx) > TRACE_BUF_FLUSH_THRESHOLD) {
flush_trace_file(false);
--
1.7.10.4
- [Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring., Harsh Prateek Bora, 2012/07/20
- [Qemu-devel] [PATCH 1/4] trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate., Harsh Prateek Bora, 2012/07/20
- [Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring,
Harsh Prateek Bora <=
- [Qemu-devel] [PATCH 3/4] trace/simple.c: remove obsolete code, Harsh Prateek Bora, 2012/07/20
- [Qemu-devel] [PATCH 2/4] trace/simple.c: remove unnecessary typecasting, Harsh Prateek Bora, 2012/07/20
- Re: [Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring., Stefan Hajnoczi, 2012/07/30