Re: [Qemu-devel] [PATCH V2 2/3] qerror: Add error telling that streaming blocks migration

[Peter Maydell]

On 23 July 2012 12:23,  <address@hidden> wrote:
> --- a/qerror.c
> +++ b/qerror.c
> @@ -283,6 +283,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "Could not set password",
>      },
>      {
> +        .error_fmt = QERR_STREAMING_BLOCKS_MIGRATION,
> +        .desc      = "Streaming blocks migration",
> +    },

An error should be a description of something that went wrong
("this isn't supported", "I couldn't do X", "couldn't find Y",
"that isn't valid on devices of type Z"). This text isn't
describing anything that's gone wrong in any comprehensible
way.

In particular I just parsed "Streaming blocks migration"
as "(streaming blocks) migration" ie "migration of
streaming blocks". If you meant "Migration was blocked
by streaming" or something similar you need to rephrase.

-- PMM