qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState
Date: Tue, 24 Jul 2012 11:33:55 +0100

On Mon, Jul 23, 2012 at 9:57 PM, Laszlo Ersek <address@hidden> wrote:
> On 07/20/12 14:01, Stefan Hajnoczi wrote:
>> @@ -970,7 +895,7 @@ void qmp_set_link(const char *name, bool up, Error 
>> **errp)
>>  done:
>>
>>      if (!vc) {
>> -        error_set(errp, QERR_DEVICE_NOT_FOUND, name);
>> +        qerror_report(QERR_DEVICE_NOT_FOUND, name);
>>          return;
>>      }
>
> Why? The only caller (at this point) seems to be hmp_set_link(), and it
> handles the error (with monitor_printf()).

Looks like a rebase/merge issue.  Thanks for pointing it out.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]