[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState |
Date: |
Tue, 24 Jul 2012 11:33:55 +0100 |
On Mon, Jul 23, 2012 at 9:57 PM, Laszlo Ersek <address@hidden> wrote:
> On 07/20/12 14:01, Stefan Hajnoczi wrote:
>> @@ -970,7 +895,7 @@ void qmp_set_link(const char *name, bool up, Error
>> **errp)
>> done:
>>
>> if (!vc) {
>> - error_set(errp, QERR_DEVICE_NOT_FOUND, name);
>> + qerror_report(QERR_DEVICE_NOT_FOUND, name);
>> return;
>> }
>
> Why? The only caller (at this point) seems to be hmp_set_link(), and it
> handles the error (with monitor_printf()).
Looks like a rebase/merge issue. Thanks for pointing it out.
Stefan
- [Qemu-devel] [PATCH 00/16] net: Move legacy QEMU VLAN code into net/hub.c, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 08/16] net: Remove VLANState, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 14/16] net: cleanup deliver/deliver_iov func pointers, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 07/16] net: Remove vlan code from net.c, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 11/16] net: Rename vc local variables to nc, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control, Stefan Hajnoczi, 2012/07/20
- [Qemu-devel] [PATCH 02/16] net: Use hubs for the vlan feature, Stefan Hajnoczi, 2012/07/20