[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqc
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel() |
Date: |
Wed, 25 Jul 2012 18:47:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-07-25 17:40, Andreas Färber wrote:
> Am 25.07.2012 15:24, schrieb Peter Maydell:
>> Now we've cleared out the architecture-independent uses of
>> kvm_irqchip_in_kernel(), we can add a doc comment describing
>> what it means.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> kvm.h | 11 +++++++++++
>> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> If you've cleared the arch-independent uses, can't it be moved out of
> the generic kvm.h? Otherwise if just the commit message is confusing me:
kvm_irqchip_in_kernel is still a generic service as it probes a generic
property - that just has arch-dependent detail semantics.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, (continued)
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Jan Kiszka, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Jan Kiszka, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq, Avi Kivity, 2012/07/25
[Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel(), Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 5/6] kvm: Don't assume irqchip implies MSI routing via irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 3/6] kvm: Move kvm_allows_irq0_override() to target-i386, Peter Maydell, 2012/07/25
[Qemu-devel] [PATCH 1/6] kvm: Decouple 'interrupt injection is async' from 'kernel irqchip', Peter Maydell, 2012/07/25