[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped |
Date: |
Wed, 25 Jul 2012 18:45:21 +0100 |
On 25 July 2012 17:54, Luiz Capitulino <address@hidden> wrote:
(Subject should be "to be", not "be".)
> A future commit will add a new qapi script which escapes that character.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> scripts/qapi.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index e062336..9aa518f 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -21,7 +21,9 @@ def tokenize(data):
> elif data[0] == "'":
> data = data[1:]
> string = ''
> - while data[0] != "'":
> + while True:
> + if data[0] == "'" and string[len(string)-1] != "\\":
> + break
> string += data[0]
> data = data[1:]
> data = data[1:]
Won't this cause us to look at string[-1] if
the input data has two ' characters in a row?
(also, maybe infinite loop if the input string has an
unterminated ' ?)
-- PMM
- Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py, (continued)
- [Qemu-devel] [PATCH 03/11] qerror: rename QERR_QMP_EXTRA_MEMBER, Luiz Capitulino, 2012/07/25
- [Qemu-devel] [PATCH 08/11] qapi: add qapi-schema-errors.json, Luiz Capitulino, 2012/07/25
- [Qemu-devel] [PATCH 04/11] qerror: rename QERR_PROPERTY_VALUE_NOT_POWER_OF_2, Luiz Capitulino, 2012/07/25
- [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh, Luiz Capitulino, 2012/07/25
- [Qemu-devel] [PATCH 02/11] qerror: rename QERR_SOCK_CONNECT_IN_PROGRESS, Luiz Capitulino, 2012/07/25
- [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Luiz Capitulino, 2012/07/25
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Luiz Capitulino, 2012/07/25
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Markus Armbruster, 2012/07/26
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Luiz Capitulino, 2012/07/26
- Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped, Markus Armbruster, 2012/07/26
- [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped, Markus Armbruster, 2012/07/26
- Re: [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped, Peter Maydell, 2012/07/26
- Re: [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped, Luiz Capitulino, 2012/07/27
- Re: [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped, Markus Armbruster, 2012/07/28
- Re: [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped, Luiz Capitulino, 2012/07/30