[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NO
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE |
Date: |
Thu, 26 Jul 2012 14:02:50 -0300 |
On Thu, 26 Jul 2012 18:59:30 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 26/07/2012 18:49, Luiz Capitulino ha scritto:
> > On Thu, 26 Jul 2012 17:41:01 +0200
> > Paolo Bonzini <address@hidden> wrote:
> >
> >> Il 26/07/2012 17:26, Kevin Wolf ha scritto:
> >>>> The DeviceNotActive error is not a particularly good match, add
> >>>>> a separate one.
> >>>>>
> >>>>> Signed-off-by: Paolo Bonzini <address@hidden>
> >>> Luiz, what do you think about this one? It seems to contradict the idea
> >>> of having only few error classes and free form error descriptions.
> >>
> >> I agree, but that's what we have to live with for now...
> >
> > Why don't you add QERR_INVALID_STATE then?
>
> Because I do want a meaningful error message.
It's fine with me adding QERR_BLOCK_JOB_NOT_ACTIVE then, as you've said,
it's what we have today.
[Qemu-devel] [PATCH 05/47] block: add support for job pause/resume, Paolo Bonzini, 2012/07/24
[Qemu-devel] [PATCH 04/47] block: add block_job_query, Paolo Bonzini, 2012/07/24
[Qemu-devel] [PATCH 06/47] qmp: add block-job-pause and block-job-resume, Paolo Bonzini, 2012/07/24
[Qemu-devel] [PATCH 03/47] block: move job APIs to separate files, Paolo Bonzini, 2012/07/24
[Qemu-devel] [PATCH 07/47] qemu-iotests: add test for pausing a streaming operation, Paolo Bonzini, 2012/07/24