[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command |
Date: |
Fri, 27 Jul 2012 12:37:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 07/27/2012 07:37 AM, Anthony Liguori wrote:
> This command attempts to map to the behavior of -cpu ?. Unfortunately, the
> output of this command differs wildly across targets.
>
> To accomodate this, we use a weak symbol to implement a default version of the
s/accomodate/accommodate/
> command that fails with a QERR_NOT_SUPPORTED error code. Targets can then
> override and implement this command if it makes sense for them.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> +##
> +# @CpuDefInfo:
> +#
> +# Virtual CPU definition.
> +#
> +# @name: the name of the CPU definition
> +#
> +# Since: 1.2.0
We are inconsistent in this file whether to use '1.2.0' or just '1.2';
probably worth a followup patch to clean whichever version is deemed
inappropriate.
> +##
> +{ 'type': 'CpuDefInfo',
> + 'data': { 'name': 'str' } }
> +
> +##
> +# @query-cpudefs:
I though QMP favored English words, as in 'query-cpu-definitions'
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 3/7] qapi: add query-machines command, (continued)
[Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 7/7] target-ppc: add implementation of query-cpudefs, Anthony Liguori, 2012/07/27
[Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpudefs, Anthony Liguori, 2012/07/27
Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output, Luiz Capitulino, 2012/07/27