Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests

[Peter Maydell]

On 28 July 2012 13:09, Blue Swirl <address@hidden> wrote:
> On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell
> <address@hidden> wrote:
>> On 28 July 2012 10:04, Blue Swirl <address@hidden> wrote:
>>>, I'm getting configure breakage in some cases:
>>
>> The thesis of the patch series is that these represent bugs to be fixed.
>
> Yes, but then the errors should be fixed by the series. When adding
> new GCC warning flags, I also fixed the causes for the warning first.
> Committing known build breakages is not OK.

I fixed all the ones I saw on my system, obviously. I'll have a look
at this one.

I think it would be worth committing patches 1-10 now anyway : those fix
configure issues (patch 1 in particular fixes the problem of tests
silently failing when they should pass).

-- PMM