Re: [Qemu-devel] [PATCH 43/47] mirror: allow customizing the granularity

[Eric Blake]

On 07/30/2012 07:40 AM, Paolo Bonzini wrote:
> Il 28/07/2012 15:43, Eric Blake ha scritto:
>>>> +    if (granularity < 512 || granularity > 1048576 * 64) {
>>>> +        error_set(errp, QERR_INVALID_PARAMETER, device);
>>>> +        return;
>>>> +    }
>>>> +    if (granularity & (granularity - 1)) {
>>>> +        error_set(errp, QERR_INVALID_PARAMETER, device);
>>>> +        return;
>> In the XBZLRE migration series, we decided to round the users input down
>> to a power of two instead of reject it.  Should we do that here?
> 
> I can certainly do that, but do you have a pointer to the discussion so
> that I can understand the rationale?

https://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02421.html

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature