|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target |
Date: | Tue, 31 Jul 2012 17:49:03 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 |
Am 31.07.2012 17:00, schrieb Peter Maydell:
On 31 July 2012 15:38, Daniel P. Berrange <address@hidden> wrote:Isn't using 'find' somewhat overkill here really. QEMU only creates .o and .d files in 2 levels of directory, so sure we can just avoid find entirely rm -f *.[od] */*.[od]That's exactly the bug this change is addressing (in a more general way than a couple of the proposed point fixes). There are subdirectories of hw/, so for instance we have a hw/usb/bus.o which your rm would not delete. -- PMM
Yes, QEMU creates files in 3 levels. We could use rm -f *.[od] */*.[od] */*/*.[od] I suggest using the wrapper $(call quiet-command,...) to suppress printing of all removed file names. For me, your patch using find would also be sufficient. Only developers use "make clean", and they should know how to name files. Even if there are files with blanks in their name, in most cases nothing bad will happen (as long as they are not named "-rf .. .o" which would be the worst scenario I can imagine). Regards, Stefan W.
[Prev in Thread] | Current Thread | [Next in Thread] |