Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

[Gleb Natapov]

Looks good to me.

On Mon, Jul 23, 2012 at 03:22:26PM +0200, Igor Mammedov wrote:
> v2:
>   ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(),
>   to keep cpu_init implementation in -softmmu and -user targets the same
>   in single place and maintanable.
> 
> v3:
>   reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set
> 
> tree for testing:
>   https://github.com/imammedo/qemu/tree/x86_reset_v3
> 
> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets
> 
> Igor Mammedov (2):
>   target-i386: move cpu halted decision into x86_cpu_reset
>   target-i386: move cpu_reset and reset callback to cpu.c
> 
>  hw/apic.h            |    5 ++++-
>  hw/apic_common.c     |   16 +++++++++++++---
>  hw/pc.c              |   18 +-----------------
>  target-i386/cpu.c    |   30 ++++++++++++++++++++++++++++++
>  target-i386/helper.c |    1 -
>  target-i386/kvm.c    |    4 +++-
>  6 files changed, 51 insertions(+), 23 deletions(-)

--
                        Gleb.