[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_su
Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage
Wed, 01 Aug 2012 16:03:17 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
On 08/01/2012 04:01 PM, Stefan Hajnoczi wrote:
> On Wed, Aug 1, 2012 at 1:56 PM, Avi Kivity <address@hidden> wrote:
>> On 07/26/2012 01:45 AM, Tyler Hall wrote:
>>> subpage_register() expects "end" to be the last byte in the mapping.
>>> Registering a non-page-aligned memory region that extends up to or
>>> beyond a page boundary causes subpage_register() to silently fail
>>> through the (end >= PAGE_SIZE) check.
>>> This bug does not cause noticeable problems for mappings that do not
>>> extend to a page boundary, though they do register an extra byte.
>> Reviewed-by: Avi Kivity <address@hidden>
> Thanks Avi. Does this include Patch 2/2 too?
I reviewed that as well with similar results.
error compiling committee.c: too many arguments to function