qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde
Date: Wed, 1 Aug 2012 16:37:39 +0100

On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang
<address@hidden> wrote:
> add-cow will let raw file support snapshot_blkdev indirectly.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> ---
>  blockdev.c              |   45 +++++++++++++++++++++++++++++++++++++--------
>  docs/live-block-ops.txt |   11 ++++++++++-
>  2 files changed, 47 insertions(+), 9 deletions(-)

This patch would need to update qapi-schema.json and qmp-commands.hx
to make use of the new arguments.

I don't think QEMU compiles cleanly after this patch.  It's important
to keep the build clean after every patch so that git-bisect(1) can be
used (if you hit a broken build during a bisect it makes things
harder).

However, I think the QMP/HMP changes should not be included in this
series unless you are sure the interface is stable.  When you convert
QEMUOptionsParameter will transaction or snapshot-blkdev-sync change?
If so, please only send the add-cow image format and leave the QMP/HMP
changes until you have the QemuOpts solution.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]