qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/6] add-cow file format


From: Dong Xu Wang
Subject: Re: [Qemu-devel] [PATCH 3/6] add-cow file format
Date: Thu, 2 Aug 2012 15:20:53 +0800

On Wed, Aug 1, 2012 at 11:31 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang
> <address@hidden> wrote:
>> +    if (backing_filename) {
>> +        header.features |= ADD_COW_F_BACKING_FILE;
>> +        header.backing_filename_offset = sizeof(header) + 16 * 2;
>
> It's not obvious what 16 * 2 is.

Okay we give meaningful constant later.

>
>> +    ret = bdrv_pwrite(bs, sizeof(le_header) + 16,
>> +        image_format ? image_format : "raw",
>> +        image_format ? sizeof(image_format) : sizeof("raw"));
>
> sizeof(image_format)?  I think this should be strlen(image_format).

Okay. thanks.

>
> Stefan
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]