[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V |
Date: |
Thu, 02 Aug 2012 10:56:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> Also, for consistency with other occurrences, implement VMSTATE_TIMER
> as a special case of VMSTATE_TIMER_V rather than VMSTATE_TIMER_TEST.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> vmstate.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/vmstate.h b/vmstate.h
> index 5bd2b76..092f21d 100644
> --- a/vmstate.h
> +++ b/vmstate.h
> @@ -503,8 +503,11 @@ extern const VMStateInfo vmstate_info_unused_buffer;
> #define VMSTATE_TIMER_TEST(_f, _s, _test) \
> VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
>
> +#define VMSTATE_TIMER_V(_f, _s, _v) \
> + VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *)
> +
> #define VMSTATE_TIMER(_f, _s) \
> - VMSTATE_TIMER_TEST(_f, _s, NULL)
> + VMSTATE_POINTER(_f, _s, 0, vmstate_info_timer, QEMUTimer *)
You didn't did it, it should be something like:
#define VMSTATE_TIMER(_f, _s) \
- VMSTATE_TIMER_TEST(_f, _s, NULL)
+ VMSTATE_TIMER_V(_f, _s, 0)
>
> #define VMSTATE_TIMER_ARRAY(_f, _s, _n) \
> VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)
- [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 02/10] RTC: Rename rtc_timer_update, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V, Paolo Bonzini, 2012/08/01
- Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V,
Juan Quintela <=
- [Qemu-devel] [PATCH 06/10] RTC: Add divider reset support, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 07/10] RTC: Do not fire timer periodically to catch next alarm, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 09/10] RTC: Remove the current_tm field, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 08/10] RTC: Get and set time without going through s->current_tm, Paolo Bonzini, 2012/08/01