Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table

[Amos Kong]

On 08/03/2012 09:32 PM, Luiz Capitulino wrote:
> On Fri,  3 Aug 2012 10:48:40 +0800
> Amos Kong <address@hidden> wrote:
> 
>> key_defs[] in monitor.c is a mapping table of keys and keycodes,
>> this patch added a QKeyCode enum and a new key_defs table,
>> Key's index in the enmu is same as keycode's index in new key_defs[].
>>
>> Signed-off-by: Amos Kong <address@hidden>
>> ---
>>  input.c          |  146 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  qapi-schema.json |   26 ++++++++++
>>  2 files changed, 172 insertions(+), 0 deletions(-)
>>
>> diff --git a/input.c b/input.c
>> index 6968b31..680d756 100644
>> --- a/input.c
>> +++ b/input.c
>> @@ -37,6 +37,152 @@ static QTAILQ_HEAD(, QEMUPutMouseEntry) mouse_handlers =
>>  static NotifierList mouse_mode_notifiers = 
>>      NOTIFIER_LIST_INITIALIZER(mouse_mode_notifiers);
>>  
>> +static const int key_defs[] = {
> 
> Weird, I expected this would brake the build, as the new table is unused.
> 
> Anyway, what I suggested in my last review was to do the table move in a
> different patch, which includes adding the new accessors, dropping key_defs
> from the monitor and doing the necessary changes in the monitor functions
> which access key_defs directly.
> 
> This way, the patch converting sendkey() to the qapi does just the
> conversion itself (vs. conversion plus refactorings).

Ok. I would split convert patch to two patches, and do the refactorings
in first patch.

Thanks, Amos