Re: [Qemu-devel] [PATCH 0/3] Move CPU model definitions to C

[Eduardo Habkost]

On Wed, Aug 01, 2012 at 01:53:51PM -0500, Anthony Liguori wrote:
> Eduardo Habkost <address@hidden> writes:
> 
> > This makes the change we discussed on the latest KVM conf call[1], moving 
> > the
> > existing cpudefs from cpus-x86_64.conf to the C code.
> >
> > The config file data was converted to C using a script, available at:
> > https://gist.github.com/3229602
> >
> > Except by the extra square brackets around the CPU model names (indicating 
> > they
> > are built-in models), the output of "-cpu ?dump" is exactly the same before 
> > and
> > after applying this series.
> >
> > [1] http://article.gmane.org/gmane.comp.emulators.kvm.devel/95328
> 
> Whole series:
> 
> Reviewed-by: Anthony Liguori <address@hidden>
> 
> I'll wait a little bit for others to look and then apply.

Just checking: you still plan to include this on 1.2, right?

> 
> Regards,
> 
> Anthony Liguori
> 
> >
> > Eduardo Habkost (3):
> >   i386: add missing CPUID_* constants
> >   move CPU models from cpus-x86_64.conf to C
> >   eliminate cpus-x86_64.conf file
> >
> >  Makefile                           |   1 -
> >  arch_init.c                        |   1 -
> >  sysconfigs/target/cpus-x86_64.conf | 128 ----------------------
> >  target-i386/cpu.c                  | 219 
> > +++++++++++++++++++++++++++++++++++++
> >  target-i386/cpu.h                  |  22 ++++
> >  5 files changed, 241 insertions(+), 130 deletions(-)
> >  delete mode 100644 sysconfigs/target/cpus-x86_64.conf
> >
> > -- 
> > 1.7.11.2
> 

-- 
Eduardo