[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for
From: |
Meador Inge |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property |
Date: |
Mon, 13 Aug 2012 15:34:27 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120424 Thunderbird/12.0 |
On 08/13/2012 10:31 AM, Peter Maydell wrote:
> Fix an incorrect default value for the num-irqs property (we were
> attempting to override it from the default set by the parent class
> but not succeeding, which meant that the lm3s6965evb model would
> assert on startup attempting to wire up nonexistent irq lines).
> Instead of trying to override the parent's Property array, we
> define an instance_init function which runs after default setup
> but before user property setting and can just fix up the default
> value in the gic_state struct.
>
> Reported-by: Peter Crosthwaite <address@hidden>
> Tested-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
I noticed this assertion recently as well while hacking on some Cortex-M3 stuff:
qemu-system-arm: /home/meadori/Code/src/qemu/hw/qdev.c:310: qdev_get_gpio_in:
Assertion `n >= 0 && n < dev->num_gpio_in' failed.
Aborted (core dumped)
I just tried out your patch and it fixes the issue I was seeing.
Tested-by: Meador Inge <address@hidden>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
- [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 05/10] hw/sd.c: introduce wrapper for conversion address to wp group, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 09/10] ssd0323: abort() instead of exit(1) on error., Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 07/10] hw/sd.c: make sd_dataready() return bool, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 06/10] hw/sd.c: convert binary variables to bool, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property, Peter Maydell, 2012/08/13
- Re: [Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property,
Meador Inge <=
- [Qemu-devel] [PATCH 04/10] hw/sd.c: make sd_wp_addr() accept 64 bit address argument, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 02/10] armv7m: Guard against no -kernel argument, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 08/10] hw/sd.c: make sd_wp_addr() return bool, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 03/10] hw/sd.c: convert wp_groups in SDState to bitfield, Peter Maydell, 2012/08/13
- [Qemu-devel] [PATCH 10/10] arm: Move some ARM devices into libhw, Peter Maydell, 2012/08/13
- Re: [Qemu-devel] [PULL for-1.2 00/10] arm-devs queue, Anthony Liguori, 2012/08/13