[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] trace: avoid pointer aliasing in trace_record_f
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 4/6] trace: avoid pointer aliasing in trace_record_finish() |
Date: |
Tue, 14 Aug 2012 13:56:26 +0100 |
From: Harsh Prateek Bora <address@hidden>
Declaring a TraceRecord on the stack works fine. No need for a
uint8_t array and pointer aliasing.
Signed-off-by: Harsh Prateek Bora <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
trace/simple.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 4fed07f..8e175ec 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -269,12 +269,11 @@ static unsigned int write_to_buffer(unsigned int idx,
void *dataptr, size_t size
void trace_record_finish(TraceBufferRecord *rec)
{
- uint8_t temp_rec[sizeof(TraceRecord)];
- TraceRecord *record = (TraceRecord *) temp_rec;
- read_from_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ TraceRecord record;
+ read_from_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
smp_wmb(); /* write barrier before marking as valid */
- record->event |= TRACE_RECORD_VALID;
- write_to_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
+ record.event |= TRACE_RECORD_VALID;
+ write_to_buffer(rec->tbuf_idx, &record, sizeof(TraceRecord));
if ((trace_idx - writeout_idx) > TRACE_BUF_FLUSH_THRESHOLD) {
flush_trace_file(false);
--
1.7.10.4
- [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 1/6] trace: rename TraceRecordHeader to TraceLogHeader, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 2/6] trace: remove unnecessary write_to_buffer() typecasting, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 6/6] trace/simple: Replace asprintf by g_strdup_printf, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 3/6] trace: drop unused TraceBufferRecord->next_tbuf_idx field, Stefan Hajnoczi, 2012/08/14
- [Qemu-devel] [PATCH 4/6] trace: avoid pointer aliasing in trace_record_finish(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 5/6] trace/simple: Fix compiler warning for 32 bit hosts, Stefan Hajnoczi, 2012/08/14
- Re: [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2, Anthony Liguori, 2012/08/14