Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

[Blue Swirl]

On Tue, Aug 14, 2012 at 6:38 PM, Peter Maydell <address@hidden> wrote:
> On 14 August 2012 19:27, Blue Swirl <address@hidden> wrote:
>> On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell <address@hidden> wrote:
>>> The code to initialise the target_to_host_errno_table[] array was
>>> accidentally inside the loop through checking and initialising all
>>> the supported ioctls. This was harmless but meant that we reinitialised the
>>> array several hundred times on startup.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>>  linux-user/syscall.c |   10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>>> index 3ba3ef5..1af68d2 100644
>>> --- a/linux-user/syscall.c
>>> +++ b/linux-user/syscall.c
>>> @@ -4606,6 +4606,11 @@ void syscall_init(void)
>>>  #undef STRUCT
>>>  #undef STRUCT_SPECIAL
>>>
>>> +    /* Build target_to_host_errno_table[] table from
>>> +     * host_to_target_errno_table[]. */
>>> +    for (i=0; i < ERRNO_TABLE_SIZE; i++)
>>
>> Please add spaces around '=' and braces.
>
> I agree that might be nice but (a) this is just code motion

Since pure CODING_STYLE patches are not appreciated, the only way to
fix style issues is to always handle them when code is touched.

> (b) it's
> a bit impolite to make review comments at the final pull request
> stage rather than when the patches were posted on the list for
> review some weeks ago.

I agree, but I don't review linux-user patches so often.

>
> -- PMM