Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

[Kevin Wolf]

Am 14.08.2012 18:56, schrieb Benoît Canet:
> Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit :
>> Am 10.08.2012 19:48, schrieb Benoît Canet:
>>> Le Tuesday 07 Aug 2012 à 20:30:09 (+0000), Blue Swirl a écrit :
>>>> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet <address@hidden> wrote:
>>>>> Signed-off-by: Benoit Canet <address@hidden>
>>>>> ---
>>>>>  block/quorum.c |   62 
>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>>  1 file changed, 62 insertions(+)
>>>>>
>>>>> diff --git a/block/quorum.c b/block/quorum.c
>>>>> index e0405b6..de58ab8 100644
>>>>> --- a/block/quorum.c
>>>>> +++ b/block/quorum.c
>>>>> @@ -47,11 +47,73 @@ struct QuorumAIOCB {
>>>>>      int vote_ret;
>>>>>  };
>>>>>
>>>>> +/* Valid quorum filenames look like
>>>>> + * quorum:path/to/a_image:path/to/b_image:path/to/c_image
>>>>
>>>> This syntax would mean that stacking for example curl or other network
>>>> paths would not be possible. How about comma as separator?
>>>
>>> I just tried comma but it fail because the qemu command line parsing
>>> catch it believing that the string next to the coma is another "file="
>>> like options.
>>>
>>> Is there any other separator we can use ?
>>
>> I would ignore that for now, or you can introduce your own escaping of
>> colons. The real solution is, once again, -blockdev.
> 
> Is -blockdev related to BlockBackend ?

BlockBackend is a prerequisite for it.

One of the goals with -blockdev is to have not only a filename for
bdrv_open from which you can parse options, but that you can get
structured and driver-specific options.

Kevin